Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIMS-2086: Remove getPIDs function #2677

Merged
merged 5 commits into from
Sep 13, 2024
Merged

PIMS-2086: Remove getPIDs function #2677

merged 5 commits into from
Sep 13, 2024

Conversation

LawrenceLau2020
Copy link
Collaborator

🎯 Summary

PIMS-2086

Changes

Testing

  • Not sure if there's much to test other than making sure this didn't break anything. After merging it will hopefully resolve that issue.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Sep 13, 2024
@github-actions GitHub Actions
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2677. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 13, 2024 •
edited
Loading

Code Climate has analyzed commit 50f2049 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.8%.

View more on Code Climate.

@LawrenceLau2020 LawrenceLau2020 merged commit 6321d6d into main Sep 13, 2024
9 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-2086 branch September 13, 2024 18:22
dbarkowsky added a commit that referenced this pull request Sep 17, 2024
@LawrenceLau2020 @dbarkowsky
PIMS-2086: Remove getPIDs function (#2677)
0e958e1 
Co-authored-by: dbarkowsky <dylanbarkowsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@LawrenceLau2020 LawrenceLau2020

Labels
Express
Projects
PIMS
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LawrenceLau2020 @dbarkowsky